Fix TypeError when faithfulness context chunk text is None - #76
Open
hadbiaghiles wants to merge 1 commit into
Open
Fix TypeError when faithfulness context chunk text is None#76hadbiaghiles wants to merge 1 commit into
hadbiaghiles wants to merge 1 commit into
Conversation
Treat chunk text of None the same as a missing key so context join never receives None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FaithfulnessChecker.check()concatenates context withchunk.get("text", ""). When a chunk has thetextkey set toNone,.get()returnsNone(the default only applies to missing keys), and" ".join(...)raises:Fix
Treat
text: Nonelike a missing/empty value by joiningchunk.get("text") or "". That keeps missing keys, empty strings, andNoneall join-safe without changing scoring for real text.Testing
xfailontest_none_context_chunk_textso the original crash case is expected to pass.[{"text": None}, {"text": "Knows Python well"}]chunk list to confirmNonealongside real text is also join-safe.Fixes #60