Repository navigation
Conversation
actions/checkout and shivammathur/setup-php were referenced by tag (@v7, @v2), which whoever controls those repositories can move: the next run would execute what they put there. They are pinned to the commits of v7.0.1 and 2.40.0, with the release in a comment; Dependabot (github-actions) proposes the updates. tests/lint/check-workflows.php, run by the lint job, fails on a reference that is not pinned. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LhhhdjhErC9ZiaS4HyRjsh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The workflows use
actions/checkout@v7andshivammathur/setup-php@v2. A tag can be moved by whoever controls the action's repository (or whoever takes it over); the next run of our workflows would then execute what they put there - with this repository's token, in its checkouts, and in the jobs that install and test the release code. Pinning to a commit SHA makes the workflow run exactly what was reviewed.Change
ci.yml,dependencies.yml) are pinned, with the release in a comment so the pins stay readable:actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1(whatv7pointed to)shivammathur/setup-php@eb7c497e18156a6bbabfef1d3a82760b9eda3962 # 2.40.0(the commitv2pointed to; resolved withgit ls-remote, annotated tag dereferenced)tests/lint/check-workflows.php, run by the lint job, fails on anyuses:that is not pinned to a 40-character SHA or lacks the release comment (local./actions excluded). I checked that it fails on an unpinned reference. The script is identical in com_bfstop (separate PR there).github-actionsentry proposes pin updates (it understands@sha # vX.Y.Z).No change to what the workflows do. The runs of this PR are the proof that the pinned commits work.
Generated by Claude Code