test: add SQL equality assertion helper#10299
Open
memleakd wants to merge 1 commit into
Open
Conversation
- Add assertSqlEquals() to CIUnitTestCase - Document the helper in the testing guide - Use the helper in representative Query Builder tests Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
assertSqlEquals()toCIUnitTestCase.This follows up on @datamweb's suggestion to introduce this helper.
The helper keeps a small pattern we already use in many Query Builder tests in one place:
It intentionally stays conservative and only ignores newlines in the actual SQL. It does not lowercase, trim, or normalize whitespace more broadly, so SQL assertions remain strict while avoiding the repeated
str_replace("\n", ' ', ...)calls.I also updated the testing docs and converted a few representative Query Builder assertions to show the intended usage. Broader migration of existing SQL assertions can happen separately after the helper is available.
Checklist: