fix: infer git service from remote in local adapter for empty upload - #741
Open
sentry[bot] wants to merge 1 commit into
Open
fix: infer git service from remote in local adapter for empty upload#741sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an AssertionError occurring during
empty-uploadwhen thegit_servicecould not be automatically determined, particularly in local environments without an explicit--git-serviceflag.Previously, the
LocalAdapter's_get_git_servicemethod returnedNone, and if theGitVersioningSystemalso failed to infer the service (e.g., no configured git remote), thevalidate_upload_servicecall would raise aClickExceptionbefore the actual upload request was sent. This caused tests to fail and preventedempty-uploadfrom working in such scenarios.The fix involves:
_get_git_serviceincodecov_cli/helpers/ci_adapters/local.pyto infer the git service from the local git remote URL. This logic mirrors the existingparse_git_servicefunctionality already present inGitVersioningSystem, allowing the CLI to correctly identify the git service (e.g., "github", "gitlab") when a remote is configured.validate_upload_servicecall incodecov_cli/commands/empty_upload.pyto maintain consistency with other CLI commands, which rely on validation within the service layer.This ensures that
empty-uploadcan successfully determine the git service in common local development setups, allowing the upload process to proceed as expected.Fixes CLI-FG