Skip to content

chore: Add 'localNpm' Maven build profile and 'npm.registry' Maven property to accomodate the UI build in corporate environments #5465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cdprete wants to merge 1 commit into
base: master
Choose a base branch
from
+94 −4
Open

chore: Add 'localNpm' Maven build profile and 'npm.registry' Maven property to accomodate the UI build in corporate environments #5465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
<spring-javaformat-maven-plugin.version>0.0.47</spring-javaformat-maven-plugin.version>
<central-publishing-maven-plugin.version>0.10.0</central-publishing-maven-plugin.version>
<spring-conf-prop-documenter-maven-plugin.version>0.7.2</spring-conf-prop-documenter-maven-plugin.version>
<exec-maven-plugin.version>3.6.3</exec-maven-plugin.version>
</properties>

<modules>
Expand Down Expand Up @@ -432,6 +433,11 @@
<artifactId>spring-configuration-property-documenter-maven-plugin</artifactId>
<version>${spring-conf-prop-documenter-maven-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>${exec-maven-plugin.version}</version>
</plugin>
</plugins>
</pluginManagement>
</build>
Expand Down
92 changes: 88 additions & 4 deletions spring-boot-admin-server-ui/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@

<properties>
<ui-resources.relative-path>META-INF/spring-boot-admin-server-ui</ui-resources.relative-path>

<npm.install.args>ci --prefer-offline --no-progress --no-audit --silent</npm.install.args>
<npm.build.args>run build</npm.build.args>
<npm.lint.args>run lint</npm.lint.args>
<npm.test.args>run test</npm.test.args>
<!-- To be set explicitly with -Dnpm.registry=https://foo.bar if the standard registry is not wanted or not accessible -->
<npm.registry />
</properties>

<dependencies>
Expand Down Expand Up @@ -122,6 +129,83 @@
</plugins>
</build>
</profile>
<!--
Profile: localNpm
Set this profile to run frontend related build steps using the local NPM installation.
Skipping frontend tests can be achieved by using default flag -D skipTests.
-->
<profile>
<id>localNpm</id>
<build>
<plugins>
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>

<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<executions>
<execution>
<id>npm-install</id>
<phase>generate-resources</phase>
<goals>
<goal>exec</goal>
</goals>
<configuration>
<executable>npm</executable>
<commandlineArgs>${npm.install.args}</commandlineArgs>
<environmentVariables>
<NPM_CONFIG_REGISTRY>${npm.registry}</NPM_CONFIG_REGISTRY>
</environmentVariables>
</configuration>
</execution>
<execution>
<id>npm-build</id>
<phase>generate-resources</phase>
<goals>
<goal>exec</goal>
</goals>
<configuration>
<executable>npm</executable>
<commandlineArgs>${npm.build.args}</commandlineArgs>
<environmentVariables>
<PROJECT_VERSION>${project.version}</PROJECT_VERSION>
</environmentVariables>
</configuration>
</execution>
<execution>
<id>npm-lint</id>
<phase>verify</phase>
<goals>
<goal>exec</goal>
</goals>
<configuration>
<executable>npm</executable>
<commandlineArgs>${npm.lint.args}</commandlineArgs>
</configuration>
</execution>
<execution>
<id>npm-test</id>
<phase>test</phase>
<goals>
<goal>exec</goal>
</goals>
<configuration>
<skip>${skipTests}</skip>
<executable>npm</executable>
<commandlineArgs>${npm.test.args}</commandlineArgs>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>

<build>
Expand Down Expand Up @@ -155,7 +239,7 @@
<goal>npm</goal>
</goals>
<configuration>
<arguments>ci --prefer-offline --no-progress --no-audit --silent</arguments>
<arguments>${npm.install.args}</arguments>
</configuration>
</execution>
<execution>
Expand All @@ -164,7 +248,7 @@
<goal>npm</goal>
</goals>
<configuration>
<arguments>run build</arguments>
<arguments>${npm.build.args}</arguments>
<environmentVariables>
<PROJECT_VERSION>${project.version}</PROJECT_VERSION>
</environmentVariables>
Expand All @@ -177,7 +261,7 @@
</goals>
<phase>verify</phase>
<configuration>
<arguments>run lint</arguments>
<arguments>${npm.lint.args}</arguments>
</configuration>
</execution>
<execution>
Expand All @@ -187,7 +271,7 @@
</goals>
<phase>test</phase>
<configuration>
<arguments>run test</arguments>
<arguments>${npm.test.args}</arguments>
</configuration>
</execution>
</executions>
Expand Down