Conversation
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: JackDevAU <jpr178@live.com.au> Co-authored-by: Jack Pettit [SSW] <57518417+JackDevAU@users.noreply.github.com>
…#6673) ## Summary Fixes #6653 Code blocks with metadata in the infostring (the part after the language identifier) were silently stripped on every save through TinaCMS. For example: **Before editing:** ````markdown ```js {1,3-5} console.log('hello'); ``` ```` **After saving:** ````markdown ```js console.log('hello'); ``` ```` The `{1,3-5}` was lost. Same issue for `title="app.py"` and any other infostring metadata. ## Root cause Three places all needed a one-line fix: 1. **Type** (`parse/plate.ts`) — `CodeBlockElement` had no `meta` field 2. **Parser** (`parse/remarkToPlate.ts`) — `meta` was read from the mdast `Code` node but never forwarded to the Plate element 3. **Serializer** (`stringify/index.ts`) — only `lang` was written back to the output mdast node; `meta` was dropped ## Changes - Add `meta?: string` to `CodeBlockElement` - Forward `content.meta` in the parser - Emit `meta` in the serializer - Add a round-trip test (`markdown-basic-code-block-meta`) covering line-highlight syntax (`{1,3-5}`) and file-name annotation (`title="app.py"`) ## Test plan - [ ] Existing `markdown-basic-code-block` test still passes - [ ] New `markdown-basic-code-block-meta` test passes (parse + serialize round-trip) - [ ] Manually verified with a `.md` file containing ` ```js {1,3-5} ` — meta survives a TinaCMS save --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )