Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Meta:
model = FormulaField
fields = list(
set(FormulaFieldType.serializer_field_names)
- {"available_collaborators", "select_options"}
- {"available_collaborators", "select_options", "number_negative"}
)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def get_serializer_field_names(cls) -> List[str]:
return cls.all_fields()

@classmethod
def get_serializer_field_overrides(cls) -> List[str]:
def get_serializer_field_overrides(cls) -> dict[str, any]:
return {}

@property
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,18 @@ class BaserowFormulaNumberType(
can_group_by = True
can_have_db_index = True

@classmethod
def get_serializer_field_names(cls):
return super().get_serializer_field_names() + ["number_negative"]

@classmethod
def get_serializer_field_overrides(cls):
return super().get_serializer_field_overrides() | {
"number_negative": serializers.BooleanField(
required=False, read_only=True, default=True
),
}

def __init__(
self,
number_decimal_places: int,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1451,6 +1451,7 @@ def test_updating_formula_field_doesnt_reset_all_fields(data_fixture, api_client
"formula_type": "date",
"nullable": True,
"number_decimal_places": None,
"number_negative": True,
}
actual = {key: value for key, value in response.json().items() if key in expected}
assert actual == expected
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "bug",
"message": "Fix negative sign in formula output disappearing when a cell is selected",
"issue_origin": "github",
"issue_number": 4323,
"domain": "database",
"bullet_points": [],
"created_at": "2026-04-10"
}
Loading