[pull] main from firecrawl:main#615
Merged
Merged
Conversation
…status
Customers had no way to determine actual crawl wall-clock time from the
API. GET /v2/crawl/{id} now returns:
- createdAt (ISO timestamp from StoredCrawl.createdAt)
- completedAt (ISO timestamp of the last finished child scrape, only
present when the crawl is in a terminal state)
- duration (seconds; createdAt to completedAt for terminal crawls, or
createdAt to now for in-progress crawls)
Adds getLastDoneJobTimestamp helper in crawl-redis.ts that reads the
highest score from the existing crawl:{id}:jobs_donez_ordered ZSET.
Applies to both /v2/crawl/{id} and /v2/batch/scrape/{id} since both
routes share crawlStatusController.
OpenAPI schema and a snip test that asserts the new fields are present
and consistent are included.
Co-Authored-By: micahstairs <micah@sideguide.dev>
Previously when a crawl failed at kickoff, GET /v2/crawl/{id} returned
duration = (now - createdAt), which grew on every subsequent poll even
though the crawl was already in a terminal state. A kickoff failure
finishes instantly, so return a stable duration of 0 and set
completedAt to createdAt.
Identified by cubic.
Co-Authored-By: micahstairs <micah@sideguide.dev>
feat(v2/crawl): expose createdAt, completedAt, and duration on crawl status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )