Repository navigation
Launcher refactor - #3148
Closed
daxgames wants to merge 12 commits into
Closed
Launcher refactor#3148daxgames wants to merge 12 commits into
daxgames wants to merge 12 commits into
Conversation
* upstream/main: (23 commits) docs: keep status prose undated and compare branch tips docs: keep unfinished work active regardless of age fix(legacy): derive product versions only from release tags Preserve native 32-bit Git layout selection Fix code review finding in vendor name end anchoring Fix Git for Windows UCRT64 startup paths fix: address vendor release badge review findings Report successful regression checks to the Actions shell Fix build helper argument handling and vendor name validation Fix code review finding: document shared startup cache precedence Complete PR head-ref environment handling across all workflows ci: read the PR head ref from the environment instead of interpolating it into PowerShell Fix code review finding: restore native ConEmu architecture selection Fix code review finding: initialize shared terminal settings on first user-root launch Prepare 2.0 RC package names and preserve upgrade paths fix: restore TCC and TCCLE shell defaults Fix code review finding: reject malformed launcher options safely Use main for current work and retire automatic development sync Fix code review finding: bound launcher path copies and API capacities Fix code review guidance and finish pending launcher help requests ... # Conflicts: # launcher/src/CmderLauncher.cpp
Member
Author
|
The command-line construction issue from #3117 is now included here in 167bc19, with regression coverage in d46db30. The launcher no longer builds its command line by overlapping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cmder.bat:Cmder.exe conemu ...Cmder.exe windows-terminal ...The launcher reports a clear error if the requested bundled terminal is unavailable.
/cconfiguration selection deterministic: machine-specific settings, then user settings, then the bundled fallback./title,/icon,/single, or/moptions are used while Windows Terminal is selected. Raw/xand--arguments remain pass-through arguments for the selected terminal.Compatibility
/croots because it cannot select a settings file per launch.conemuselector.Tests
/cmachine-specific ConEmu settings, legacy configuration migration, explicit terminal selectors, unavailable requested terminals, and unsupported-option diagnostics.Run Testspassed on the PR, including Win32 and x64 launcher regression tests.