Add collapsible behavior to term edit page#1174
Open
gabrielcld2 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approach
taxonomies.jsto support multiple collapsible instances per page usingquerySelectorAll, resolving content targets via adata-collapsible-targetattribute andgetElementById. Visibility is now toggled viathe
hiddenattribute (replacingstyle.display) to correctly handle both<div>and<tbody>elements. Arrow icon state usesclassList.togglewith a force argument.aria-expanded,aria-controls, andaria-labelto all collapsible toggle buttons for screen reader accessibility..cloudinary-collapsibleinto a--cardBEM modifier in_settings.scss, keeping layout-specific styles separate from the shared toggle/content rules. Extended the__toggleheading selector to cover both
h2andh3.taxonomy-transformation-fields.phpto use the--cardmodifier, wire updata-collapsible-target/idon the toggle and content elements, and replacestyle="display:none"with thehiddenattribute.taxonomy-term-transformation-fields.phpusing paired<tbody>elements per transformation context — a toggle row containing the heading and button, and a content<tbody>(initiallyhidden) wrapping the existing field rows — preserving valid table structure throughout.cloudinary-term-transformationsto thetbodyelements added by Cloudinary so that it can be targeted for custom styling if needed.QA notes