Repository navigation
Revert PXC 8.4.11 forced sql_require_primary_key - #142
Merged
Merged
Conversation
Effectively reverts PXC-5106 and related workarounds so pxc-strict-mode no longer forces sql_require_primary_key=ON. This restores schema migrations that create a table and add its primary key in separate statements, while preserving strict-mode rejection of writes to tables without a primary key. This will be reverted in Percona XtraDB Cluster v8.4.13 in the next quarter and this change will be removed at that time. This is a temporary backwards compatibility fix. This commit patches the Percona XtraDB Cluster v8.4.11 source tree during the bosh compile phase. Additionally system tests were added to validate the expected primary key workflow. These tests fail against a vanilla Percona XtraDB Cluster v8.4.11 cluster and pass with the changes in this commit.
kimago
approved these changes
Oct 8, 2026
kimago
left a comment
kimago
left a comment
Member
There was a problem hiding this comment.
Passes AI+HI review, approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effectively reverts PXC-5106 and related workarounds so pxc-strict-mode no longer forces sql_require_primary_key=ON. This restores schema migrations that create a table and add its primary key in separate statements, while preserving strict-mode rejection of writes to tables without a primary key.
This will be reverted in Percona XtraDB Cluster v8.4.13 in the next quarter and this change will be removed at that time. This is a temporary backwards compatibility fix.
This commit patches the Percona XtraDB Cluster v8.4.11 source tree during the bosh compile phase. Additionally system tests were added to validate the expected primary key workflow. These tests fail against a vanilla Percona XtraDB Cluster v8.4.11 cluster and pass with the changes in this commit.