Skip to content

Adjust framework functionalities for the new dependencies paths#1286

Merged
ramonskie merged 7 commits into
cloudfoundry:mainfrom
kiril-keranov:patch-31
May 19, 2026
Merged

Adjust framework functionalities for the new dependencies paths#1286
ramonskie merged 7 commits into
cloudfoundry:mainfrom
kiril-keranov:patch-31

Conversation

@kiril-keranov
Copy link
Copy Markdown
Contributor

@kiril-keranov kiril-keranov commented May 19, 2026

After recent dependency updates with regard to automatic PR creation from the dependency pipeline and cflinuxfs5 adjustments some of the jar dependencies paths and names were changed. Adapting the corresponding frameworks and tests with regard to these changes.
Linked to #1281, #1278, #1273, #1271, #1272

@ramonskie
Copy link
Copy Markdown
Contributor

f.jarPath is always an empty string "" at the start of Supply(). os.Stat("") always returns "not found", so the JAR is re-downloaded on every staging — the caching optimization is bypassed entirely.

Fix: Construct the expected path before the existence check (as the original code did), or call constructJarPath first and only download if it fails.

@kiril-keranov
Copy link
Copy Markdown
Contributor Author

f.jarPath is always an empty string "" at the start of Supply(). os.Stat("") always returns "not found", so the JAR is re-downloaded on every staging — the caching optimization is bypassed entirely.

Fix: Construct the expected path before the existence check (as the original code did), or call constructJarPath first and only download if it fails.

This was for the cf-metrics-exporter framework modifications right, I changed it

@ramonskie ramonskie merged commit 713375b into cloudfoundry:main May 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants