You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After recent dependency updates with regard to automatic PR creation from the dependency pipeline and cflinuxfs5 adjustments some of the jar dependencies paths and names were changed. Adapting the corresponding frameworks and tests with regard to these changes.
Linked to #1281, #1278, #1273, #1271, #1272
f.jarPath is always an empty string "" at the start of Supply(). os.Stat("") always returns "not found", so the JAR is re-downloaded on every staging — the caching optimization is bypassed entirely.
Fix: Construct the expected path before the existence check (as the original code did), or call constructJarPath first and only download if it fails.
f.jarPath is always an empty string "" at the start of Supply(). os.Stat("") always returns "not found", so the JAR is re-downloaded on every staging — the caching optimization is bypassed entirely.
Fix: Construct the expected path before the existence check (as the original code did), or call constructJarPath first and only download if it fails.
This was for the cf-metrics-exporter framework modifications right, I changed it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After recent dependency updates with regard to automatic PR creation from the dependency pipeline and
cflinuxfs5adjustments some of the jar dependencies paths and names were changed. Adapting the corresponding frameworks and tests with regard to these changes.Linked to #1281, #1278, #1273, #1271, #1272