[go-migration] Refactor common context, generate mocks, fix hollow unit tests for supply/finalize#1177
Open
kiril-keranov wants to merge 6 commits intocloudfoundry:feature/go-migrationfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR introduces the following changes:
contextstruct to use newly introduced interfaces to libbuildpack functionalities in order to be able to generate mocks. The mocks are further used in supply unit tests.supplyphase unit tests that always passed and tested nothing. The generated mocks provide the ability to run supply phase without doing real download of dependencies.supply.Run(..)supply.Run(..)supply.Run(..)finalizephase unit tests that always passed and tested nothing.finalize.Run(..)finalize.Run(..)finalize.Run(..)Addressing this issue
Additional change is also adjusting the
cf-metrics-exportertests