feat: wrap AI, Images, Analytics Engine, Vectorize and RateLimit Bindings to accept native Python objects#130
feat: wrap AI, Images, Analytics Engine, Vectorize and RateLimit Bindings to accept native Python objects#130ryanking13 wants to merge 5 commits into
Conversation
|
The change is straightforward. Let me review the complete picture:
The change is minimal and clean. The only thing I notice is the absence of a parallel test for the AI binding — but the same rationale applies (AI needs a real account), and arguably if you can't even configure a local AI binding in wrangler, there's nothing to test. The PR description explains this clearly. The code is correct — LGTM |
Now that we have a good BindingWrapper class, these just work. Unfortunately AI and Vectorize bindings require a real prod account even for the local testing, so we cannot run unittest in CI.
I verified them working my making a demo worker with my local account + patched sdk.
Vectorize test worker
This requires 64-dimension DB in the account
AI test worker