fix: ensure Worker subclasses are wrapped only once#126
Merged
Conversation
|
The test structure matches the existing patterns. The fix is clean, the approach is correct, and the tests are thorough. The implementation correctly handles all the edge cases:
LGTM |
dom96
approved these changes
Jun 16, 2026
dom96
left a comment
Contributor
There was a problem hiding this comment.
Thanks! See comment for small refactoring nit.
hoodmane
reviewed
Jun 16, 2026
hoodmane
reviewed
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #125
Our
_wrap_subclasshad an issue that when there is a subclass that inherits the wrapped WorkerEntrypoint/DurableObject, the_wrap_subclassis called multiple times, double wrapping theenvorctxattributes.We always had that issue but it was surfaced by my recent change in the DO (#112)
This fixes it by adding a guarder variable and applying the wrapper function only once.