Skip to content

Accept span completion after request teardown - #7016

Open
apeacock1991 wants to merge 1 commit into
mainfrom
apeacock/fix-span-without-current-request
Open

Accept span completion after request teardown#7016
apeacock1991 wants to merge 1 commit into
mainfrom
apeacock/fix-span-without-current-request

Conversation

@apeacock1991

Copy link
Copy Markdown
Contributor

IoContext tasks may close spans after their IncomingRequest is destroyed. The tracer already records the request completion time for this case, but still emitted a warning and Sentry alert.

Use the recorded timestamp without warning when it is available. Keep the warning when neither a current request nor completion time exists, and cover request teardown and replacement-request timing.

IoContext tasks may close spans after their IncomingRequest is
destroyed. The tracer already records the request completion time for
this case, but still emitted a warning and Sentry alert.

Use the recorded timestamp without warning when it is available. Keep
the warning when neither a current request nor completion time exists,
and cover request teardown and replacement-request timing.
@apeacock1991
apeacock1991 requested review from a team as code owners August 14, 2026 19:40
@ask-bonk

ask-bonk Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

2 similar comments
@ask-bonk

ask-bonk Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@apeacock1991 Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@codspeed-hq

codspeed-hq Bot commented Aug 14, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 9.19%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 71 untouched benchmarks
⏩ 129 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
bm_Promise_Fib10 18.5 µs 20.3 µs -9.19%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing apeacock/fix-span-without-current-request (11daa68) with main (9c08f8a)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant