Accept span completion after request teardown - #7016
Conversation
IoContext tasks may close spans after their IncomingRequest is destroyed. The tracer already records the request completion time for this case, but still emitted a warning and Sentry alert. Use the recorded timestamp without warning when it is available. Keep the warning when neither a current request nor completion time exists, and cover request teardown and replacement-request timing.
|
APIError: Invalid Anthropic API Key |
2 similar comments
|
APIError: Invalid Anthropic API Key |
|
APIError: Invalid Anthropic API Key |
|
@apeacock1991 Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Merging this PR will degrade performance by 9.19%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | bm_Promise_Fib10 |
18.5 µs | 20.3 µs | -9.19% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing apeacock/fix-span-without-current-request (11daa68) with main (9c08f8a)
Footnotes
-
129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
IoContext tasks may close spans after their IncomingRequest is destroyed. The tracer already records the request completion time for this case, but still emitted a warning and Sentry alert.
Use the recorded timestamp without warning when it is available. Keep the warning when neither a current request nor completion time exists, and cover request teardown and replacement-request timing.