fix(artifacts): align binding result types - #7009
Open
dmmulroy wants to merge 5 commits into
Open
Conversation
Contributor
Author
Merging this PR will not alter performance
Comparing Footnotes
|
The token itself encodes its expiry as `art_v1_<secret>?expires=<unix_seconds>`, making the separate `tokenExpiresAt` field redundant.
ArtifactsRepoListResult now returns full ArtifactsRepoInfo[] instead of Omit<ArtifactsRepoInfo, 'remote'>[], matching the backend change in artifacts MR !106.
dmmulroy
force-pushed
the
fix/artifacts-binding-result-types
branch
from
August 14, 2026 16:29
903342a to
4cc9c99
Compare
danlapid
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #6602 with the branch rebased onto current
mainand snapshots regenerated through the supported pipeline. The original commits retain @mattzcarey as author.The Artifacts provider intentionally removed
tokenExpiresAtbecause the returned token encodes expiry as?expires=<unix_seconds>. This updatesArtifactsCreateRepoResultaccordingly and documents the token encoding. It also retains #6602’s follow-up correction that listed repositories includeremote.Validation
just generate-types(rerun clean; generated snapshots match)just formatbazel test //types/...(26/26 passed)