Skip to content

fix(artifacts): align binding result types - #7009

Open
dmmulroy wants to merge 5 commits into
cloudflare:mainfrom
dmmulroy:fix/artifacts-binding-result-types
Open

fix(artifacts): align binding result types#7009
dmmulroy wants to merge 5 commits into
cloudflare:mainfrom
dmmulroy:fix/artifacts-binding-result-types

Conversation

@dmmulroy

Copy link
Copy Markdown
Contributor

Supersedes #6602 with the branch rebased onto current main and snapshots regenerated through the supported pipeline. The original commits retain @mattzcarey as author.

The Artifacts provider intentionally removed tokenExpiresAt because the returned token encodes expiry as ?expires=<unix_seconds>. This updates ArtifactsCreateRepoResult accordingly and documents the token encoding. It also retains #6602’s follow-up correction that listed repositories include remote.

Validation

  • just generate-types (rerun clean; generated snapshots match)
  • just format
  • bazel test //types/... (26/26 passed)

@dmmulroy

Copy link
Copy Markdown
Contributor Author

@NuroDev You approved the original #6602. This is the same change rebased onto current main, with snapshots regenerated to resolve the previous check-snapshot failure.

@codspeed-hq

codspeed-hq Bot commented Aug 14, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks1


Comparing dmmulroy:fix/artifacts-binding-result-types (0a8f4e0) with main (5b87a2c)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

The token itself encodes its expiry as `art_v1_<secret>?expires=<unix_seconds>`,
making the separate `tokenExpiresAt` field redundant.
ArtifactsRepoListResult now returns full ArtifactsRepoInfo[] instead of
Omit<ArtifactsRepoInfo, 'remote'>[], matching the backend change in
artifacts MR !106.
@dmmulroy
dmmulroy force-pushed the fix/artifacts-binding-result-types branch from 903342a to 4cc9c99 Compare August 14, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants