Skip to content

STOR-5542: Allow alarms not to retry when calling ctx.abort() - #6996

Open
apeacock1991 wants to merge 2 commits into
mainfrom
apeacock/no-retry-alarm-abort
Open

STOR-5542: Allow alarms not to retry when calling ctx.abort()#6996
apeacock1991 wants to merge 2 commits into
mainfrom
apeacock/no-retry-alarm-abort

Conversation

@apeacock1991

Copy link
Copy Markdown
Contributor

Give the ability for alarms to opt out of future retries when calling ctx.abort(), which currently produces a non-catchable error that guarantees at least one more run of the alarm.

Preserve the signal through both handler and output-gate error paths, with the latter being able to potentially override the abort signal and trigger a retry.

@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

2 similar comments
@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@apeacock1991 Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@codspeed-hq

codspeed-hq Bot commented Aug 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks1


Comparing apeacock/no-retry-alarm-abort (43ddb05) with main (3d43d41)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Allow Durable Object aborts to opt out of retrying the current alarm. Report calls to state.abort() with EventOutcome::ABORTED instead of EXCEPTION.

Preserve the abort and no-retry signals across immediate and output-gate failures. Use the outcome to abandon terminal alarms in the local scheduler.
Update stable and experimental type snapshots with the optional retryAlarm setting and the aborted trace outcome.
@apeacock1991
apeacock1991 force-pushed the apeacock/no-retry-alarm-abort branch from 03f2449 to 43ddb05 Compare August 14, 2026 09:47
@apeacock1991
apeacock1991 marked this pull request as ready for review August 14, 2026 10:07
@apeacock1991
apeacock1991 requested review from a team as code owners August 14, 2026 10:07
@apeacock1991 apeacock1991 changed the title Allow alarms not to retry when calling ctx.abort() STOR-5542: Allow alarms not to retry when calling ctx.abort() Aug 14, 2026

@petebacondarwin petebacondarwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a typings point of view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants