STOR-5542: Allow alarms not to retry when calling ctx.abort() - #6996
Open
apeacock1991 wants to merge 2 commits into
Open
STOR-5542: Allow alarms not to retry when calling ctx.abort()#6996apeacock1991 wants to merge 2 commits into
apeacock1991 wants to merge 2 commits into
Conversation
Contributor
|
APIError: Invalid Anthropic API Key |
2 similar comments
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
@apeacock1991 Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Merging this PR will not alter performance
Comparing Footnotes
|
Allow Durable Object aborts to opt out of retrying the current alarm. Report calls to state.abort() with EventOutcome::ABORTED instead of EXCEPTION. Preserve the abort and no-retry signals across immediate and output-gate failures. Use the outcome to abandon terminal alarms in the local scheduler.
Update stable and experimental type snapshots with the optional retryAlarm setting and the aborted trace outcome.
apeacock1991
force-pushed
the
apeacock/no-retry-alarm-abort
branch
from
August 14, 2026 09:47
03f2449 to
43ddb05
Compare
apeacock1991
marked this pull request as ready for review
August 14, 2026 10:07
petebacondarwin
approved these changes
Aug 14, 2026
petebacondarwin
left a comment
Contributor
There was a problem hiding this comment.
Approving from a typings point of view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give the ability for alarms to opt out of future retries when calling ctx.abort(), which currently produces a non-catchable error that guarantees at least one more run of the alarm.
Preserve the signal through both handler and output-gate error paths, with the latter being able to potentially override the abort signal and trigger a retry.