Skip to content

Fix incorrect comments misnaming jsgrs jsg::Rc - #6994

Merged
LordGoatius merged 1 commit into
mainfrom
cloudflare/jimmyostler/jsgrs-remove-ref-comments
Aug 17, 2026
Merged

Fix incorrect comments misnaming jsgrs jsg::Rc#6994
LordGoatius merged 1 commit into
mainfrom
cloudflare/jimmyostler/jsgrs-remove-ref-comments

Conversation

@LordGoatius

Copy link
Copy Markdown
Contributor

At some point it was renamed, but the comments weren't fixed.

@LordGoatius
LordGoatius requested review from a team as code owners August 13, 2026 18:39
@LordGoatius LordGoatius self-assigned this Aug 13, 2026
@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

1 similar comment
@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@LordGoatius Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@LordGoatius
LordGoatius force-pushed the cloudflare/jimmyostler/jsgrs-remove-ref-comments branch from 0547b74 to 7b0b5c3 Compare August 13, 2026 20:16
@LordGoatius
LordGoatius enabled auto-merge (rebase) August 13, 2026 20:32
@LordGoatius
LordGoatius force-pushed the cloudflare/jimmyostler/jsgrs-remove-ref-comments branch from 7b0b5c3 to c32c314 Compare August 14, 2026 14:57
@codspeed-hq

codspeed-hq Bot commented Aug 14, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 12.81%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 71 untouched benchmarks
⏩ 129 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
JsString_Utf8Length_Utf16_Invalid_NonFlat_256 9.5 µs 10.9 µs -12.81%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing cloudflare/jimmyostler/jsgrs-remove-ref-comments (edfd314) with main (bd568a9)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@LordGoatius
LordGoatius force-pushed the cloudflare/jimmyostler/jsgrs-remove-ref-comments branch 7 times, most recently from d00bf77 to 99266d8 Compare August 17, 2026 19:51
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@LordGoatius
LordGoatius force-pushed the cloudflare/jimmyostler/jsgrs-remove-ref-comments branch from 99266d8 to edfd314 Compare August 17, 2026 20:31
@LordGoatius
LordGoatius merged commit b6424d1 into main Aug 17, 2026
22 checks passed
@LordGoatius
LordGoatius deleted the cloudflare/jimmyostler/jsgrs-remove-ref-comments branch August 17, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants