TlsAcceptCallbacks support for rustls backend#908
Open
dpfeifer2 wants to merge 1 commit into
Open
Conversation
b8dac96 to
58dd7b4
Compare
58dd7b4 to
75df529
Compare
Author
|
Hey @nojima , @johnhurt and @jsulmont , not much seems to have happened regarding #833 for a while. I would like to get the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support TlsAcceptCallbacks for the rustls backend
Ports the
TlsAcceptCallbackssupport from upstream #833, excluding the parts flagged in review there: that PR bundles unrelated changes (intentional webpki policy bypass on cert loading, custom ServerCertVerifier support in the connector) which @nojima asked to split into a separate PR (#833 (comment)) for independent security discussion. This PR takes only the callbacks feature.Changes
•
TlsSettings::with_callbacks(cb)now works with rustls (previously returned an error); addedset_certificate_chain_file()/set_private_key_file()andset_cert_resolver()for dynamic cert selection•
TlsRefextended from an empty struct to expose post-handshake state.•
handshake_with_callback()passes a populatedTlsReftohandshake_complete_callback, matching the OpenSSL/BoringSSL behavior• Added
test_handshake_complete_callbackintegration testDeviations from #833
• No webpki bypass: cert/key loading still goes through with_single_cert()
• Test uses the ring provider instead of aws_lc_rs