Skip to content

Remove Beta badge from Egress Policy Host Selector (now GA) - #32878

Closed
takuro-fuk wants to merge 3 commits into
cloudflare:productionfrom
takuro-fuk:patch-1
Closed

Remove Beta badge from Egress Policy Host Selector (now GA)#32878
takuro-fuk wants to merge 3 commits into
cloudflare:productionfrom
takuro-fuk:patch-1

Conversation

@takuro-fuk

Copy link
Copy Markdown
Contributor

Remove Beta badge from Egress Policy Host Selector (now GA)

Summary

Screenshots (optional)

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The change adheres to the documentation style guide.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 3 warnings found in commit e517cdb.

👉 Fix in your agent 👈
Fix the following review findings in PR #32878 (https://github.com/cloudflare/cloudflare-docs/pull/32878).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Warnings (1)

#### CR-44055ee8d6e8 · Accessible description does not match visible content
- **File:** `src/components/cf/HostSelectorEgressDiagram.astro` line 12
- **Issue:** The `aria-label` says Cloudflare Gateway 'matches the connection to a Host, Domain, Application, or Content Categories policy', but the visible node caption (lines 49–50) only says 'matches the connection to a Host egress policy'. Screen-reader users hear a broader, different policy scope than sighted users.
- **Fix:** Align the `aria-label` with the visible caption (e.g., change it to 'Host egress policy') or update the visible caption to mention all four selector types.

---

## Conventions

### Warnings (2)

#### CV-dfbf14355842 · Description explains the work
- **File:** PR-level finding
- **Issue:** The PR description contains only the unfilled template with no human-written explanation of the change.
- **Fix:** Add a brief sentence describing what changed and why.

#### CV-33c0917d192a · Scope accuracy
- **File:** PR-level finding
- **Issue:** The PR adds a new 272-line component (src/components/cf/HostSelectorEgressDiagram.astro) and removes an image asset (src/assets/images/cloudflare-one/policies/host-selector-diagram.png), but the title/description only mentions removing a Beta badge.
- **Fix:** Mention the new Astro diagram component and asset removal in the PR description.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
src/components/cf/HostSelectorEgressDiagram.astro line 12 Accessible description does not match visible content — The aria-label says Cloudflare Gateway 'matches the connection to a Host, Domain, Application, or Content Categories policy', but the visible node caption (lines 49–50) only says 'matches the connection to a Host egress policy'. Screen-reader users hear a broader, different policy scope than sighted users. Fix: Align the aria-label with the visible caption (e.g., change it to 'Host egress policy') or update the visible caption to mention all four selector types.

Conventions

Warnings (2)
File Issue
PR Description explains the work — The PR description contains only the unfilled template with no human-written explanation of the change. Fix: Add a brief sentence describing what changed and why.
PR Scope accuracy — The PR adds a new 272-line component (src/components/cf/HostSelectorEgressDiagram.astro) and removes an image asset (src/assets/images/cloudflare-one/policies/host-selector-diagram.png), but the title/description only mentions removing a Beta badge. Fix: Mention the new Astro diagram component and asset removal in the PR description.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@nikitacano

Copy link
Copy Markdown
Contributor

/review

2. When traffic arrives with this temporary destination IP, Gateway can identify which hostname the connection belongs to, apply the correct egress policy, then replace the temporary IP with the real destination IP before forwarding the traffic.

![Example egress policy flow](~/assets/images/cloudflare-one/policies/host-selector-diagram.png)
<HostSelectorEgressDiagram />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this'll resolve correctly, you'll need a deeper reference -- which makes sense -- b/c this isn't in the barrel file

takuro-fuk and others added 3 commits August 21, 2026 14:32
Remove Beta badge from Egress Policy Host Selector (now GA)
Replace the static host-selector-diagram.png with a new
HostSelectorEgressDiagram.astro component, showing the flow for
egress policy host selectors to a public hostname: client request ->
Gateway resolves a temporary initial resolved IP from the current
default public range (172.64.128.0/20) and matches it to a Host
selector policy -> traffic egresses to the real public destination.

Follows the same visual pattern as TunnelHostnameRoutingDiagram.astro
and WorkersVPCEgressDiagram.astro. Removes the now-unreferenced PNG
asset.
Per review feedback from kodster28: single-use components like this
one aren't added to src/components.ts (following the same pattern as
ArtifactsCIPipelineDiagram, AvailableChangelogFeeds, and other
one-off diagram components) -- import directly from the component's
own path instead.
@nikitacano

Copy link
Copy Markdown
Contributor

Opening #32917 instead.

@nikitacano nikitacano closed this Aug 21, 2026
auto-merge was automatically disabled August 21, 2026 14:43

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants