Remove Beta badge from Egress Policy Host Selector (now GA) - #32878
Closed
takuro-fuk wants to merge 3 commits into
Closed
Remove Beta badge from Egress Policy Host Selector (now GA)#32878takuro-fuk wants to merge 3 commits into
takuro-fuk wants to merge 3 commits into
Conversation
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #32878 (https://github.com/cloudflare/cloudflare-docs/pull/32878).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (1)
#### CR-44055ee8d6e8 · Accessible description does not match visible content
- **File:** `src/components/cf/HostSelectorEgressDiagram.astro` line 12
- **Issue:** The `aria-label` says Cloudflare Gateway 'matches the connection to a Host, Domain, Application, or Content Categories policy', but the visible node caption (lines 49–50) only says 'matches the connection to a Host egress policy'. Screen-reader users hear a broader, different policy scope than sighted users.
- **Fix:** Align the `aria-label` with the visible caption (e.g., change it to 'Host egress policy') or update the visible caption to mention all four selector types.
---
## Conventions
### Warnings (2)
#### CV-dfbf14355842 · Description explains the work
- **File:** PR-level finding
- **Issue:** The PR description contains only the unfilled template with no human-written explanation of the change.
- **Fix:** Add a brief sentence describing what changed and why.
#### CV-33c0917d192a · Scope accuracy
- **File:** PR-level finding
- **Issue:** The PR adds a new 272-line component (src/components/cf/HostSelectorEgressDiagram.astro) and removes an image asset (src/assets/images/cloudflare-one/policies/host-selector-diagram.png), but the title/description only mentions removing a Beta badge.
- **Fix:** Mention the new Astro diagram component and asset removal in the PR description.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
ConventionsWarnings (2)
Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
nikitacano
requested review from
a team,
cf-rhett,
csujedihy,
jiulingz,
kodster28 and
lpraneis
as code owners
August 20, 2026 10:12
Contributor
|
/review |
nikitacano
approved these changes
Aug 20, 2026
kodster28
reviewed
Aug 21, 2026
| 2. When traffic arrives with this temporary destination IP, Gateway can identify which hostname the connection belongs to, apply the correct egress policy, then replace the temporary IP with the real destination IP before forwarding the traffic. | ||
|
|
||
|  | ||
| <HostSelectorEgressDiagram /> |
Collaborator
There was a problem hiding this comment.
I don't think this'll resolve correctly, you'll need a deeper reference -- which makes sense -- b/c this isn't in the barrel file
Remove Beta badge from Egress Policy Host Selector (now GA)
Replace the static host-selector-diagram.png with a new HostSelectorEgressDiagram.astro component, showing the flow for egress policy host selectors to a public hostname: client request -> Gateway resolves a temporary initial resolved IP from the current default public range (172.64.128.0/20) and matches it to a Host selector policy -> traffic egresses to the real public destination. Follows the same visual pattern as TunnelHostnameRoutingDiagram.astro and WorkersVPCEgressDiagram.astro. Removes the now-unreferenced PNG asset.
Per review feedback from kodster28: single-use components like this one aren't added to src/components.ts (following the same pattern as ArtifactsCIPipelineDiagram, AvailableChangelogFeeds, and other one-off diagram components) -- import directly from the component's own path instead.
Contributor
|
Opening #32917 instead. |
auto-merge was automatically disabled
August 21, 2026 14:43
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Beta badge from Egress Policy Host Selector (now GA)
Summary
Screenshots (optional)
Documentation checklist