[Workers] Document Vitest plugin migration - #32858
Merged
Merged
Conversation
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
MattieTK
marked this pull request as ready for review
August 19, 2026 13:42
MattieTK
requested review from
a team,
GregBrimble,
WalshyDev,
elithrar,
irvinebroque,
korinne,
rita3ko and
vy-ton
as code owners
August 19, 2026 13:42
MattieTK
requested review from
a team,
danlapid,
iglesiasbrandon,
joshthoward and
lambrospetrou
as code owners
August 19, 2026 13:42
Contributor
Review💡 1 suggestion found in commit 👉 Fix in your agent 👈Fix the following review findings in PR #32858 (https://github.com/cloudflare/cloudflare-docs/pull/32858).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Style Guide Review
### Suggestions (1)
#### SG-4fca45980461 · Passive voice
- **File:** `src/content/docs/workers/testing/vitest-integration/isolation-and-concurrency.mdx` line 42
- **Issue:** Line uses the passive phrase "the `nodejs_compat` flag is enabled by default."
- **Fix:** Rewrite in active voice: "because the plugin enables the `nodejs_compat` flag by default."
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. Conventions❌ This review could not complete this run; results may be incomplete. It will retry on the next push. Style Guide ReviewSuggestions (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
irvinebroque
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates Workers testing documentation for the version 1 rename from
@cloudflare/vitest-pool-workersto@cloudflare/vitest-plugin, including migration guidance and the codemod. Adds@msw/cloudflareas the recommended outbound-request mocking integration and a Workers changelog entry.Sources: cloudflare/workers-sdk#15074 and cloudflare/workers-sdk#13830
Documentation checklist
Validation
pnpm run formatpnpm run checkpnpm run format:core:checkpnpm run build(attempted; static rendering failed on an unrelated missing RealtimeKit generated chunk)