Skip to content

Comments

refactor: use starlight config to add md dirs, use starlight@0.37.6#28537

Merged
colbywhite merged 3 commits intoproductionfrom
prcssd.drs
Feb 24, 2026
Merged

refactor: use starlight config to add md dirs, use starlight@0.37.6#28537
colbywhite merged 3 commits intoproductionfrom
prcssd.drs

Conversation

@colbywhite
Copy link
Collaborator

@colbywhite colbywhite commented Feb 23, 2026

Using processedDirs removes the need to use a brute-force patch to get extra dirs processed. This prop was not available in older version of Starlight.

Removing the brute-force patch makes future upgrades simplier.

Sample URLs to compare to determine if everything is working correctly. (Don't limit your testing to just these.)

Route Prod env Preview env Consumer Partial
/changelog/2026-02-15-workers-best-practices/ URL URL src/content/changelog/workers/2026-02-15-workers-best-practices.mdx
/workers/examples/read-post/ URL URL src/content/docs/workers/examples/read-post.mdx src/content/partials/workers/request-dot-clone-warning.mdx
/workers/examples/turnstile-html-rewriter/ URL URL src/content/docs/workers/examples/turnstile-html-rewriter.mdx src/content/partials/workers/request-dot-clone-warning.mdx
/images/tutorials/optimize-user-uploaded-image/ URL URL src/content/partials/workers/request-dot-clone-warning.mdx src/content/partials/workers/request-dot-clone-warning.mdx

Using `processedDirs` removes the need to use a brute-force patch to get
extra dirs processed. This prop was not available in older version of
Starlight.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
*.ts @cloudflare/content-engineering, @kodster28
* @cloudflare/pcx-technical-writing
package.json @cloudflare/content-engineering
*.astro @cloudflare/content-engineering, @kodster28

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

@colbywhite colbywhite marked this pull request as ready for review February 23, 2026 20:48
@colbywhite colbywhite requested review from a team and kodster28 as code owners February 23, 2026 20:48
@colbywhite colbywhite enabled auto-merge (squash) February 23, 2026 20:48
metaTags.push({
property: "og:description",
content: frontmatter.description as string,
});
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This is necessary since Starlight v0.36.3 doesn't add the og:description anymore. And we have a test that explictly asserts on both the description and og:description.

Starlight made the change to prevent content=undefined scenarios. But it inadvertently broke our heavyweight custom head building. I'm not sure the full context why we are doing so much management of the head so I'm just going to leave it for now and brute force the og:description in there.

Copy link
Collaborator

@kodster28 kodster28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot checked some changes + sign off from @pedrosousa / @marciocloudflare

@colbywhite colbywhite merged commit 6537a2a into production Feb 24, 2026
11 checks passed
@colbywhite colbywhite deleted the prcssd.drs branch February 24, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants