feature/LCHIB-777: remove stop command and escape content from :: - #1373
Merged
jothikumar-CB merged 1 commit intoAug 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the gate command’s GitHub Actions output hardening by removing the ::stop-commands:: mechanism and instead escaping stderr lines that begin with ::, preventing GitHub Actions from interpreting test output as workflow commands.
Changes:
- Removed
::stop-commands::/ resume-token wrapping from GitHub Actions formatted output. - Added per-line escaping for stderr lines that start with
::(escaped to%3A%3A...). - Updated tests to assert escaped output for known dangerous command-like lines.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| launchable/commands/gate.py | Removes stop-commands usage and escapes stderr lines starting with :: before emitting them in GHA groups. |
| tests/commands/test_gate.py | Adjusts assertions to match the new escaping approach for GitHub Actions output. |
Suppressed comments (1)
tests/commands/test_gate.py:206
- These assertions confirm escaped output is present, but they don't verify the raw workflow-command lines are absent. Adding assertNotIn checks makes the test fail if both escaped and unescaped forms are ever emitted.
# dangerous :: lines are escaped so GHA won't interpret them as commands
self.assertIn('%3A%3Aerror::some error', result.output)
self.assertIn('%3A%3Awarning::spoofed', result.output)
self.assertIn('%3A%3Aadd-mask::secret-value', result.output)
self.assertIn('%3A%3Aset-output name=x::y', result.output)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ono-max
approved these changes
Aug 31, 2026
jothikumar-CB
deleted the
feature/LCHIB-777-improve-gate-command-output-v1
branch
August 31, 2026 08:57
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GitHub Actions, failure details are wrapped in
::group:: / ::endgroup::for collapsible accordions. Replaced the previous::stop-commands::approach (which caused GHA to mask the token as *** and display it literally) with per-line escaping, lines starting with :: in stderr are escaped to %3A%3A to prevent GHA from interpreting test output as workflow commands.