Skip to content

Test #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ono-max wants to merge 5 commits into from
Closed

Test #1372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffb5ee8
Test
ono-max Aug 31, 2026
e1deea7
Change exit code assertion in version test
ono-max Aug 31, 2026
7d1bc75
Fix command for recording gate in workflow
ono-max Aug 31, 2026
5a78383
Fix expected output in test_parse method
ono-max Aug 31, 2026
47f58ea
Update test_session.py
ono-max Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ jobs:
function record() {
# Record test results
LAUNCHABLE_SLACK_NOTIFICATION=true launchable record tests --session $(cat session.txt) file test-results/*.xml
launchable gate --session $(cat session.txt)
}

trap record EXIT
Expand Down
2 changes: 1 addition & 1 deletion tests/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def test_parse_session(self):
session = "builds/build-name/test_sessions/123"
build_name, session_id = parse_session(session)
self.assertEqual(build_name, "build-name")
self.assertEqual(session_id, "123")
self.assertEqual(session_id, "12")

with self.assertRaises(Exception):
parse_session("hoge/fuga")
Expand Down
2 changes: 1 addition & 1 deletion tests/test_testpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

class TestPathEncodingTest(unittest.TestCase):
def test_parse(self):
self.assertEqual(parse_test_path('a=b#c=d'), [{'type': 'a', 'name': 'b'}, {'type': 'c', 'name': 'd'}])
self.assertEqual(parse_test_path('a=b#c=d'), [{'type': 'c', 'name': 'b'}, {'type': 'c', 'name': 'd'}])
self.assertEqual(parse_test_path('&name=b#&type=c'), [{'name': 'b'}, {'type': 'c'}])
self.assertEqual(parse_test_path('t=n&a=aa&x=xx'), [{'a': 'aa', 'name': 'n', 'type': 't', 'x': 'xx'}])
self.assertEqual(parse_test_path('&a=aa&type=t&x=xx'), [{'a': 'aa', 'type': 't', 'x': 'xx'}])
Expand Down
2 changes: 1 addition & 1 deletion tests/test_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ class VersionTest(TestCase):
def test_version(self):
runner = CliRunner()
result = runner.invoke(main, ['--version'])
self.assertEqual(result.exit_code, 0)
self.assertEqual(result.exit_code, 1)
self.assertEqual(result.output, 'launchable-cli, version {}\n'.format(__version__))
Loading