[AIENG-679] Unify GitHub Actions OIDC onto the generic OIDC flow - #1366
Open
gokul-cloudbees wants to merge 4 commits into
Open
[AIENG-679] Unify GitHub Actions OIDC onto the generic OIDC flow#1366gokul-cloudbees wants to merge 4 commits into
gokul-cloudbees wants to merge 4 commits into
Conversation
…legacy flag in the header for older way
Contributor
|
Should we modify the Java part? I guess we need to do the same thing there, too. smart-tests-cli/src/main/java/com/launchableinc/ingest/commits/Main.java Lines 87 to 125 in c57ddb1 |
ono-max
reviewed
Aug 31, 2026
| # The header tells Intake to take the legacy branch; without it the token would be verified | ||
| # through the generic path. | ||
| if os.getenv(LEGACY_GITHUB_OIDC_KEY): | ||
| click.secho( |
Contributor
There was a problem hiding this comment.
This warning is within authentication_headers method, meaning that CLI will print it every time API is called. It might be annoyed, so can we think about a way to reduce the frequency?
Java commit-ingester source changed in 58359b5 but the checked-in jar was not rebuilt, failing the "Check exe_deploy.jar is up to date" CI step. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routes GitHub Actions OIDC through the same generic flow used for Jenkins. The legacy path is preserved behind an explicit opt-in.
Changes