Do not gate DB writes based on internal map#703
Merged
gabriel-samfira merged 1 commit intocloudbase:mainfrom Apr 4, 2026
Merged
Do not gate DB writes based on internal map#703gabriel-samfira merged 1 commit intocloudbase:mainfrom
gabriel-samfira merged 1 commit intocloudbase:mainfrom
Conversation
This change removes the check for the runner in the internal provider state before setting the DB instance status. We should not gate DB writes based on worker status. If the runner was removed from the DB, then the DB layer will return a not found error on anything other than create or delete. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
force-pushed
the
allow-status-set
branch
from
651d8be to
b1f5461
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the check for the runner in the internal provider state before setting the DB instance status. We should not gate DB writes based on worker status. If the runner was removed from the DB, then the DB layer will return a not found error on anything other than create or delete.