Fix clojure-add-arity severing arglist metadata#693
Open
Conversation
bbatsov
force-pushed
the
fix-add-arity-metadata
branch
from
be1b5d1 to
32c62f3
Compare
clojure-add-arity was leaving metadata annotations (^String, ^:keyword,
^{...}) stranded between the defn name and arity forms. Now metadata
stays attached to its arglist inside the arity wrapper.
bbatsov
force-pushed
the
fix-add-arity-metadata
branch
from
32c62f3 to
5d4918f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #649.
When
clojure-add-arityconverts a single-arity function to multi-arity, metadata annotations before the arglist (^String,^:keyword,^{...}) now stay attached to their arglist inside the arity wrapper instead of being left stranded.