Upgrade prometheus to 0.14.0#4598
Open
SupernaviX wants to merge 2 commits intoclockworklabs:masterfrom
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Upgrades the rust SDK's prometheus dependency from 0.13 to 0.14.
Fixes #4597
API and ABI breaking changes
The prometheus changelog claims that the MSRV for the new version is 1.82, but this project doesn't seem to have an official MSRV, so I don't think that's an ABI change.
I don't think depending on a different prometheus version is itself a breaking change. Prometheus is exposed through the rust SDK, but in an explicitly unstable module which "may change incompatibly without a major version bump". Prometheus structs are also exposed from several crates, but with the same disclaimers about unstable interfaces.
Expected complexity level and risk
Testing