Conversation
bfops
commented
Mar 4, 2026
… into bfops/fix-package-job
bfops
commented
Mar 4, 2026
bfops
commented
Mar 10, 2026
jdetter
approved these changes
Mar 11, 2026
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
Didn't test it but this seems fine for now, do we have a ticket to enable/fix signing windows binaries?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
We were unable to test #4473 because #githubworkflowthings, and it turns out we broke the job.
Here I fixed the job and merge the two jobs into one.
Signing still doesn't work so I've disabled the signing part for now.
API and ABI breaking changes
None. CI only.
Expected complexity level and risk
1
Testing
I ran a test job: https://github.com/clockworklabs/SpacetimeDB/actions/runs/22691343426/job/65787327828