Repository navigation
#31 - Give a code to the tasks, class name as service id - #32
Merged
Merged
Conversation
- Codes (cleverage/process-bundle#91): archive.zip, archive.unzip (cleverage.task tag), to reference the tasks with "task: <code>" (process-bundle 5.4 or later, "service" being deprecated there). - Service ids: the class names (as in process-bundle). Still public, but fetching the tasks directly from the service container is deprecated since 2.3 (container.private tag): private in 3.0. - Former ids cleverage_archive_process.task.zip / .unzip: deprecated aliases since 2.3, removed in 3.0. - Documentation: codes on the reference pages, examples switched to the task codes (archive and process-bundle tasks), index. Tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
archive_zip / archive_unzip instead of archive.zip / archive.unzip, to avoid name conflicts (convention of the bridge codes: "<bridge>_<name>"). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31: propagate cleverage/process-bundle#91 (PR cleverage/process-bundle#294) to this bridge. Deprecations introduced in 2.3, removal in 3.0.
Changes
archive_zip(ZipTask) andarchive_unzip(UnzipTask),cleverage.tasktag, so that the tasks are referenced withtask: archive_zip(process-bundle 5.4 or later, where referencing a task by itsserviceis deprecated).{ name: container.private, package: cleverage/archive-process-bundle, version: '2.3' }):Accessing the "…" service directly from the container is deprecated, use dependency injection instead.; private in 3.0. The references of the container (process-bundle task locator) use the private service, without deprecation.cleverage_archive_process.task.zip/cleverage_archive_process.task.unzip(released since 1.0, private): deprecated aliases of the class names since 2.3 (The "cleverage_archive_process.task.zip" service alias is deprecated, use the "archive_zip" task code or the class name of the task instead. It will be removed in 3.0.), removed in 3.0. They stay private, as before.serviceuntil those bridges get their codes (Give a code to the tasks (process-bundle#91), class name as service id doctrine-process-bundle#48, Give a code to the tasks (process-bundle#91), class name as service id flysystem-process-bundle#51);index.md(codes, service ids, deprecations).Requirement not changed yet:
cleverage/process-bundlestays^5.0, because 5.4 is not released (Composer could not resolve^5.4, the CI would fail). The change is harmless with process-bundle ≤ 5.3 (thecleverage.tasktag is ignored there;container.privateand deprecated aliases are Symfony features). To raise to^5.4before releasing 2.3 (thetask:key of the documentation requires it).Checks
mainand this branch copied invendor/, then reverted):lint:containerOK;demo.archive_unzip/demo.archive_zip(stillservice: '@<class>', i.e. the service id now) executed; a temporary process usingtask: constant_output→task: archive_unzip→task: input_folder_browserexecuted; no deprecation of this bundle in the container build log (the former ids are not used).CleverAgeArchiveProcessExtensionTest(class name as id, non-shared, code, public +container.private, former ids private deprecated aliases with their message). Aftercomposer update: 31 tests OK, PHPStan, PHP-CS-Fixer, Rector OK,composer validate --strictOK.Requirements
Breaking changes
None: the former ids and the public access are only deprecated (2.3), removed in 3.0.
🤖 Generated with Claude Code