Move non-Var GROUP BY coverage out of N-1 schedules - #8867
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8867 +/- ##
=======================================
Coverage 88.75% 88.76%
=======================================
Files 290 290
Lines 65101 65101
Branches 8219 8219
=======================================
+ Hits 57778 57784 +6
+ Misses 4949 4943 -6
Partials 2374 2374 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The coverage is preserved while correctly excluded from incompatible N-1 runs.
Review effort: Balanced
Findings: None
What changed in this PR
Moves Citus 14.3-specific non-Var GROUP BY regression coverage outside the N-1 test matrix.
Changes:
- Extracts the assertions into a standalone regression test.
- Runs the test only in the current-library create-Citus schedule.
- Removes the extracted cases from
aggregate_support.
| File | Description |
|---|---|
src/test/regress/sql/non_var_group_by.sql |
Adds the standalone test. |
src/test/regress/expected/non_var_group_by.out |
Adds expected results. |
src/test/regress/sql/aggregate_support.sql |
Removes relocated assertions. |
src/test/regress/expected/aggregate_support.out |
Removes relocated output. |
src/test/regress/multi_1_create_citus_schedule |
Schedules current-library-only coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
eaydingol
approved these changes
Sep 24, 2026
The regress assertions in #8527 require coordinator planner behavior introduced in Citus 14.3, which is unavailable when N-1 tests load the 14.2 library. Move the coverage into a standalone test under the current-library-only create-Citus schedule while preserving the existing aggregate coverage. This follows a similar pattern to #8804, which put `extract_deparse` outside the 14.2 N-1 mixed-library matrix.
Colm (colm-mchugh)
force-pushed
the
fix-8865-n1-tests
branch
from
September 24, 2026 12:58
5756579 to
9535eca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regress assertions in #8527 require coordinator planner behavior introduced in Citus 14.3, which is unavailable when N-1 tests load the 14.2 library.
Move the coverage into a standalone test under the current-library-only create-Citus schedule while preserving the existing aggregate coverage. This follows a similar pattern to #8804, which put
extract_deparseoutside the 14.2 N-1 mixed-library matrix.