fix: fold boolean OR complements to true - #252
Draft
NullWitnessZK wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247.
Minimal reproducer
Save as
main.pl:The three cases form
(!A) OR A OR (R == 5). Because!A OR Ais always true, source semantics accept everyR, includingR = 6.Compile through the normal Datalog proof pipeline at
271f911and evaluate withR = 6:Expected
The entire disjunction folds to
true.Actual
The complementary pair is deleted, leaving only
R == 5. A source-valid public input is rejected.Why it happens
The wide
BoolNaryOp::Orconstant folder removesxand!xfrom its child set instead of returningtrue. Frontends can reach this n-ary form becauseOpt::Flattenruns before the final constant-fold pass.Impact: overconstraint/completeness only.
Proposed fix
fix/cfold-or-complementat65a9c14returnstrueimmediately when either ordering of a complementary pair is found.The branch contains a self-contained regression:
cargo test b_or_complementIt checks both
or(x, !x)andor(!x, x).