fix(r1cs): route wide shifts at the bit level - #251
Draft
NullWitnessZK wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242.
Minimal reproducer
Save as
main.pl:Use:
Compare the two public results:
At CirC
271f911, raw and optimized CircIR accept only the first value. R1CS lowering and the finalized proof relation reject it and accept the second. A fresh stock proof verifies for the wrong public result.Expected
low128((2^128 - 1) << 127) = 2^127.Actual
The relation computes the low 128 bits after scalar-field reduction.
Why it happens
The lowering packs the 255-bit shifted intermediate into one BLS12-381 scalar before decomposing it. The integer exceeds the scalar modulus, so it is first reduced modulo the field.
Impact: wrong relation—both soundness and completeness.
Proposed fix
fix/u128-variable-shiftate47a41buses an LSB-first bit-routing barrel shifter and never packs the oversized intermediate into a field element.Self-contained regression:
cargo test --features r1cs target::r1cs::trans::testThe full focused R1CS translation group passes all 18 tests, including
u128SHL, LSHR, and ASHR.