Skip to content

ci: install node-gyp before pnpm install#410

Merged
coderdan merged 1 commit intomainfrom
dan/fix-node-gyp-pnpm-action-v6
May 5, 2026
Merged

ci: install node-gyp before pnpm install#410
coderdan merged 1 commit intomainfrom
dan/fix-node-gyp-pnpm-action-v6

Conversation

@coderdan
Copy link
Copy Markdown
Contributor

@coderdan coderdan commented May 5, 2026

Summary

  • Adds an npm install -g node-gyp step before pnpm install in tests.yml (both jobs) and release.yml.
  • Unblocks the pnpm/action-setup v4 → v6 bump in chore(actions): bump pnpm/action-setup from 4 to 6.0.3 #390, which currently fails because v6 no longer ships node-gyp on PATH and node-pty@1.1.0 falls back to node-gyp rebuild (no linux-x64 prebuild matches).

Why

The failing log on #390 shows:
```
node-pty install: > Rebuilding because directory .../prebuilds/linux-x64 does not exist
node-pty install: sh: 1: node-gyp: not found
ELIFECYCLE Command failed.
```
Main is currently still on pnpm/action-setup@v4 (which bundles node-gyp), so this change is a no-op on main today and only takes effect once #390 lands. Including the same step in release.yml so the release path doesn't break the moment #390 merges.

pnpm/action-setup v6 no longer ships node-gyp on PATH, so node-pty's
install hook (which falls back to `node-gyp rebuild` when no linux-x64
prebuild matches) fails. Install node-gyp globally before `pnpm install`
in the test and release workflows so the bump to v6 (#390) can land.
@coderdan coderdan requested a review from a team as a code owner May 5, 2026 07:04
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

Warning

Rate limit exceeded

@coderdan has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 49 minutes and 24 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bb446e9a-53a2-4963-935e-722297500338

📥 Commits

Reviewing files that changed from the base of the PR and between 6f67582 and 74370cd.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • .github/workflows/tests.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dan/fix-node-gyp-pnpm-action-v6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 5, 2026

⚠️ No Changeset found

Latest commit: 74370cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@auxesis auxesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks @coderdan.

@coderdan coderdan merged commit 20cc0cf into main May 5, 2026
7 checks passed
@coderdan coderdan deleted the dan/fix-node-gyp-pnpm-action-v6 branch May 5, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants