Repository navigation
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
victormlg
changed the title
victormlg
force-pushed
the
ENT-14463-part-3
branch
2 times, most recently
from
September 29, 2026 11:26
b7d8916 to
33ee80a
Compare
| VarRefDestroy(ref); | ||
| } | ||
|
|
||
| static PromiseResult KeepAgentPromise(EvalContext *ctx, const Promise *pp, ARG_UNUSED void *param) |
victormlg
force-pushed
the
ENT-14463-part-3
branch
3 times, most recently
from
September 30, 2026 15:11
f98bd05 to
36fa38f
Compare
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
ENT-14463-part-3
branch
from
September 30, 2026 15:17
36fa38f to
0f805bb
Compare
victormlg
marked this pull request as ready for review
September 30, 2026 15:18
larsewi
reviewed
Oct 1, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Please do a review with Claude. For me it found a few things that seem plausible:
- A remote
copy_fromin athenbundle crashes cf-reactor - State builds up across repeated runs of the same bundle
- The
EvalAbortedbranch is dead code
victormlg
force-pushed
the
ENT-14463-part-3
branch
2 times, most recently
from
October 1, 2026 18:13
1bb39a3 to
5a8c477
Compare
craigcomstock
approved these changes
Oct 1, 2026
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
looks good generally
larsewi
reviewed
Oct 2, 2026
victormlg
force-pushed
the
ENT-14463-part-3
branch
2 times, most recently
from
October 5, 2026 10:45
58f4f25 to
d02b0bb
Compare
Member
|
@cf-bottom jenkins, please |
olehermanse
self-requested a review
October 5, 2026 12:37
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14750/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14750/ |
Contributor
Author
Added a fix for the windows failure in enterprise. Restarted it |
Contributor
|
@victormlg for a rebuild in jenkins, it would be nice if we updated the PR with the links... so here I will do it manually: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14753/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14753/ |
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
a bit more, will continue later today
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
here's the last of my comments on the refactored-code-as-new-code... I would say my intention was mostly to have you add comments where needed in a separate commit and create tickets/todos for things I mention that you feel are valid.
larsewi
reviewed
Oct 6, 2026
…ions.c Linked TODOs to new tickets to fix old bugs/TODOs that were already in cf-agent before moving the code. Signed-off-by: Victor Moene <victor.moene@northern.tech>
Better concurrency for cf-reactor static state - No need for map anymore, since watcher keeps track of the promise - No need to keep key as variable anymore, since we do not use a map - No need to run bundle inside watcher.c - No risk of running a bundle from a wrong key between policy reads Signed-off-by: Victor Moene <victor.moene@northern.tech>
Promises are skipped to prevent running them several times. However, on event, we want to run them every single time: - we clear the promise lock cache - we set the default if_elapsed time for bundles run from an events promise to be 0, so it doesn't skip the promises. Fixed also connection cache and custom promise prologue and epilogue. Clear function cache before "then" bundle run Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
- Moved mod_methods.c's MethodsParseTreeCheck implementation to PromiseCheckBundleCallArity in policy.c, and made it more generic - Now, MethodsParseTreeCheck and EventsParseTreeCheck both call this new function when calling bundles Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
ENT-14463-part-3
branch
from
October 6, 2026 16:51
d02b0bb to
bcace8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR: #6375
Depends on: https://github.com/cfengine/enterprise/pull/1004