Escape backslashes and quotes in NT account names passed to GetGroupDN() - #73
Open
bastienperez wants to merge 1 commit into
Open
Conversation
The trustee name was injected as-is into the JavaScript onclick handler
of the HTML report, so any account name containing a JS metacharacter
produced a broken GetGroupDN('...') call:
- an apostrophe (DOMAIN\O'Brien) terminated the string literal early;
- the domain separator was read as a JS escape sequence, so CONTOSO\bob
reached GetGroupDN() as "CONTOSObob" (\b = backspace).
Backslashes and single quotes are now escaped with the JavaScript
convention (\\ and \') before interpolation, in both HTML report
generation blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trustee name was injected as-is into the JavaScript onclick handler of the HTML report, so any account name containing a JS metacharacter produced a broken GetGroupDN('...') call:
Backslashes and single quotes are now escaped with the JavaScript convention (\ and ') before interpolation, in both HTML report generation blocks.