fix: update empty states to match design system#93
Merged
Conversation
This was referenced Mar 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns Task Testing panel and Output panel empty states with the design system by updating empty-state structure, styling, and selection messaging.
Changes:
- Update
useSelectedElementto return a structuredselectionInfoobject (optional title + message) instead of a plain message string. - Refresh empty-state markup and SCSS for Task Testing and Output to match the design system (icons, typography, spacing, centering).
- Adjust tests and changelog entry to reflect the updated empty-state behavior/content.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
lib/hooks/useSelectedElement.js |
Changes hook return type to structured selectionInfo for richer empty-state messaging. |
lib/components/TaskTesting/TaskTesting.js |
Renders updated empty state using icon wrapper + optional title + description text. |
lib/components/Output/Output.jsx |
Updates Output empty-state markup to match new structure/typography expectations. |
lib/style/style.scss |
Adds/adjusts empty-state styling (layout, typography, icon sizing) and flex behavior. |
test/hooks/useSelectedElement.spec.js |
Updates expectations for selectionInfo object shape and messaging. |
test/components/TaskTesting/TaskTesting.spec.js |
Updates render assertion to the new empty-state message text. |
CHANGELOG.md |
Adds unreleased changelog entry for the empty-state update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlekseyManetov
approved these changes
Apr 1, 2026
Contributor
AlekseyManetov
left a comment
There was a problem hiding this comment.
Overall looks good! Please address Copilot comment and we can merge it.
32a8d06 to
dc2e7a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to camunda/camunda-modeler#5781
Proposed Changes
This pull request aims to bring consistency in empty states between panels.
Beware that the empty state content is vertically centered in its white space. So, alignment consistency between panels is not expected in this case. We have also considered not vertically centering it, but giving a fixed top space/gap, which would have to be maintained as panels are developed and hence, an overhead. So we did not favor it for now.
While Figma asks for 12px font-size, I have found it pretty small and went ahead with 14px for now.
npx @bpmn-io/sr camunda/camunda-modeler -l bpmn-io/variable-outline#issue-5781-update-empty-state -l camunda/task-testing#issue-5781-update-empty-statesBefore
After
Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool