Skip to content

chore: remove image-size #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilteoood wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: remove image-size #1406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57ee8b2
chore: remove image size
ilteoood Jul 7, 2026
0a202a4
fix: changeset
ilteoood Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/short-facts-camp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@callstack/repack": patch
---

remove image-size
2 changes: 1 addition & 1 deletion packages/repack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@
"exit-hook": "^4.0.0",
"flow-remove-types": "^2.277.0",
"gradient-string": "^2.0.2",
"image-size": "^1.1.1",
"jsonwebtoken": "^9.0.3",
"memfs": "^4.11.1",
"mime-types": "^2.1.35",
Expand All @@ -101,6 +100,7 @@
"schema-utils": "^4.2.0",
"semver": "^7.7.2",
"shallowequal": "^1.1.0",
"sharp": "^0.35.3",
"tapable": "^2.2.1",
"terser-webpack-plugin": "^5.3.14",
"throttleit": "^2.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/repack/src/loaders/assetsLoader/assetsLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ export default async function repackAssetsLoader(
}

const scale = getScaleNumber(scaleKey);
const dimensions = getAssetDimensions({
const dimensions = await getAssetDimensions({
resourceData: content,
resourceScale: scale,
});
Expand Down
9 changes: 5 additions & 4 deletions packages/repack/src/loaders/assetsLoader/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import path from 'node:path';
import { imageSize } from 'image-size';
import sharp from 'sharp';
import type { Asset, AssetDimensions, CollectedScales } from './types.js';

export function getScaleNumber(scaleKey: string) {
Expand All @@ -12,15 +12,16 @@ export function getAssetSize(assets: Asset[]) {
return assets[0].dimensions;
}

export function getAssetDimensions({
export async function getAssetDimensions({
resourceData,
resourceScale,
}: {
resourceData: Buffer;
resourceScale: number;
}): AssetDimensions | null {
}): Promise<AssetDimensions | null> {
try {
const info = imageSize(resourceData);
const sharpInstance = sharp(resourceData);
const info = await sharpInstance.metadata();
if (!info.width || !info.height) {
return null;
}
Expand Down
Loading
Loading