fix: apply bold fontWeight to active BottomNavigation.Bar label - #5049
Open
ErfanBagheri404 wants to merge 2 commits into
Open
fix: apply bold fontWeight to active BottomNavigation.Bar label#5049ErfanBagheri404 wants to merge 2 commits into
ErfanBagheri404 wants to merge 2 commits into
Conversation
MD3 spec requires the active navigation bar label to be bold (weight 700). Previously the same font was applied to active and inactive labels. Fixes callstack#4780
MikitasK
reviewed
Aug 20, 2026
MikitasK
left a comment
MikitasK
left a comment
There was a problem hiding this comment.
looks good 👌
just one comment from my side:
Comment on lines
716
to
718
| color: activeLabelColor, | ||
| fontWeight: '700' as TextStyle['fontWeight'], | ||
| ...font, |
There was a problem hiding this comment.
...font includes labelMedium font weight (500) & currently overwrites 700
wdyt about moving fontWeight after ...font?
Suggested change
| color: activeLabelColor, | |
| fontWeight: '700' as TextStyle['fontWeight'], | |
| ...font, | |
| color: activeLabelColor, | |
| ...font, | |
| fontWeight: '700' as TextStyle['fontWeight'], |
Author
There was a problem hiding this comment.
hello, thanks for reviewing! ill apply the changes right away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4780
MD3 spec requires the active navigation bar label to be bold (weight 700). Previously the same font was applied to both active and inactive labels.
Added
fontWeight: 700to the active label Text style inBottomNavigationBar.tsx.