fix: update Grid when dir changes - #913
Merged
Merged
Conversation
|
@imshunsuke is attempting to deploy a commit to the Brian Vaughn's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bvaughn
approved these changes
Sep 5, 2026
bvaughn
left a comment
bvaughn
left a comment
Owner
There was a problem hiding this comment.
Thanks! This is a nice improvement.
I guess if we wanted to go further we could use a mutation observer to listen for a change to the element's dir attribute, but maybe that's overkill 🙃
Owner
|
Released in react-window@2.3.1 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a mounted
Gridchanged its explicitdirprop between"ltr"and"rtl",useIsRtlkept the value from the initial render. Its layout effect only recalculated direction when no explicitdirwas provided.This updates the hook to synchronize explicit direction changes while preserving DOM and ancestor direction detection when the prop is unset. A regression test covers both
ltr→rtlandrtl→ltr.Tested with the full unit test suite, ESLint, TypeScript, Prettier, and the library and documentation production builds.