refactor(cli): remove coordinate XPath return flag - #2835
Draft
shrey150 wants to merge 4 commits into
Draft
Conversation
|
This was referenced Aug 27, 2026
shrey150
force-pushed
the
agent/browse-v4-5-remove-xpath
branch
from
August 28, 2026 02:52
fc177d4 to
58a94c2
Compare
This was referenced Aug 28, 2026
…-remove-xpath # Conflicts: # packages/cli/tests/driver-commands.test.ts
shrey150
changed the base branch from
agent/browse-v4-4-runtime
to
agent/browse-v4-network-sidecar
August 28, 2026 23:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove Browse's obsolete
--return-xpathcoordinate-action option instead of retaining a permanently unsupported V4 compatibility flag.returnXPathin driver payloads.XPath selectors and snapshot
xpathMapare unchanged. This removes only the request to return an XPath from a raw coordinate action.Stack
--return-xpath; complete supported V3 parityReview boundary
The diff from #2849 is intentionally small and is a public-contract removal only. #2834 proves the V4 runtime, #2849 restores network capture, and this PR proves that all supported V3 behavior remains after deleting the sole unsupported option.
E2E Test Matrix
All flows below used the actual built CLI against real local Chromium on this PR.
Hello CompleteParitygetandisgetters; checkbox/select/upload/highlighttypesucceeded and all variants produced expected text137px, 149px; that implementation is unchanged by the restack[]; flow result matched; 0 normalized JSON/file-mode differencesmouse click --return-xpathon current headNonexistent flag: --return-xpathget text /html/body/div/h1) plus retained snapshot coveragexpathMaptests passedThis is the first stack head with the complete supported V3 CLI surface running on V4 and no intentionally failing compatibility option.