Dispatch custom event when user accepts the policy#6
Merged
a6software merged 2 commits intodevelopfrom Feb 8, 2019
Merged
Conversation
jenkoian
approved these changes
Feb 7, 2019
jenkoian
reviewed
Feb 7, 2019
src/js/public/gdpr-public.js
Outdated
| $(window).scrollTop(Math.abs( parseInt( scrollDistance, 10 ) ) ); | ||
| $('.gdpr.gdpr-privacy-preferences .gdpr-wrapper').fadeOut(); | ||
| $('.gdpr-privacy-bar').fadeOut(); | ||
| $( document ).trigger( "updatedPrivacyPreferences" ); |
There was a problem hiding this comment.
Minor prefer single quotes as per the existing style of this file.
jenkoian
approved these changes
Feb 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of upstream PR - trewknowledge#245
Dispatch a custom event so we can do "interesting things" from elsewhere when the user accepts the policy.
In my example I want to redirect the user to the same page, but with a cache buster on the end of the URL: