fix(content-sidebar): add programmatic Resin tracking for sidebar resize#4722
fix(content-sidebar): add programmatic Resin tracking for sidebar resize#4722jmcbgaston wants to merge 1 commit into
Conversation
Resin DOM delegation only captures click/mouseup, but the resize handle uses pointer capture, so GA shipped with zero sidebarresizehandle events. Emit recordAction on resizeStart/resizeEnd and forward resin through ContentPreview. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
WalkthroughAdds ChangesSidebar resize instrumentation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.3)src/elements/content-preview/ContentPreview.jsFile contains syntax errors that prevent linting: Line 21: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 36: 'import { type x ident }' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 65: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 66: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 67: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 68: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 69: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 70: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 71: ' ... [truncated 19028 characters] ... nly feature. Convert your file to a TypeScript file or remove the syntax.; Line 1597: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 1609: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 1616: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 1648: expected src/elements/content-sidebar/ContentSidebar.jsFile contains syntax errors that prevent linting: Line 12: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 38: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 39: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 40: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 41: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 42: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 43: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 44: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 45: 'import type' ... [truncated 4077 characters] ... remove the syntax.; Line 347: return type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 348: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 366: return type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 416: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 417: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 428: expected src/elements/content-sidebar/Sidebar.jsFile contains syntax errors that prevent linting: Line 14: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 17: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 18: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 26: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 27: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 32: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 33: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 34: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 35: 'import type' ... [truncated 7124 characters] ... a semicolon or an implicit semicolon after a statement, but found none; Line 345: return type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 350: return type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 365: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 365: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 404: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 405: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
The resizable sidebar resize handle uses pointer capture (
pointerdown/pointermove/pointerup), so Resin's DOM click delegation never recordssidebarresizehandleevents.This change emits programmatic
recordActioncalls on resize start and end with width metadata, and forwards an optionalresinprop fromContentPreviewthrough toSidebarso host apps can supply the callback.Event shape:
Test plan
SidebarResizeHandle,Sidebar,ContentSidebar, andContentPreviewprop forwardingresizeStartandresizeEndwith expected payload when host suppliesresin.recordActionSemantic release type
fix- Bug fixSummary by CodeRabbit
New Features
Bug Fixes
Tests