fix(search): add search in dev and add baseUrl so search works again#57
fix(search): add search in dev and add baseUrl so search works again#57janelletam wants to merge 5 commits into
Conversation
Greptile SummaryThis PR fixes search by removing the
Confidence Score: 5/5Safe to merge — all changes are additive dev tooling improvements and a straightforward bug fix with no regressions on the critical path. The search path fix and dev script are well-scoped. The public/pagefind/ directory is correctly gitignored, the Tilt resource correctly uses cmd for the one-shot index build, and the UI refactor in search-overlay.tsx uses established patterns without introducing new state-management complexity. No files require special attention. Important Files Changed
Sequence Diagram%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
participant Dev as Developer
participant Script as pagefind:dev script
participant Astro as Astro Build
participant PF as Pagefind CLI
participant Public as public/pagefind/
participant DevSrv as Astro Dev Server
participant Browser as Browser (Search UI)
Dev->>Script: bun pagefind:dev
Script->>Astro: astro build
Astro-->>Script: build complete
Script->>PF: pagefind --site dist/docs --output-path public/pagefind
PF-->>Public: writes pagefind.js + index files
Public-->>Script: done
Dev->>DevSrv: bun dev
DevSrv-->>Browser: serves /docs/ + /docs/pagefind/ (from public/)
Browser->>DevSrv: dynamic import /docs/pagefind/pagefind.js
DevSrv-->>Browser: pagefind runtime
Browser->>DevSrv: pagefind.search(query)
DevSrv-->>Browser: sub_results[] with URLs + anchors
Browser->>Browser: flatten to SearchEntry[], highlight terms, show results
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
participant Dev as Developer
participant Script as pagefind:dev script
participant Astro as Astro Build
participant PF as Pagefind CLI
participant Public as public/pagefind/
participant DevSrv as Astro Dev Server
participant Browser as Browser (Search UI)
Dev->>Script: bun pagefind:dev
Script->>Astro: astro build
Astro-->>Script: build complete
Script->>PF: pagefind --site dist/docs --output-path public/pagefind
PF-->>Public: writes pagefind.js + index files
Public-->>Script: done
Dev->>DevSrv: bun dev
DevSrv-->>Browser: serves /docs/ + /docs/pagefind/ (from public/)
Browser->>DevSrv: dynamic import /docs/pagefind/pagefind.js
DevSrv-->>Browser: pagefind runtime
Browser->>DevSrv: pagefind.search(query)
DevSrv-->>Browser: sub_results[] with URLs + anchors
Browser->>Browser: flatten to SearchEntry[], highlight terms, show results
Reviews (2): Last reviewed commit: "refactor(search): use lucide icons" | Re-trigger Greptile |
|
@greptileai again |
Add search in dev
Add baseUrl so search works again
Reorder sidebar section so adk is right after Getting Started section to match mintlify docs