Skip to content

Add reflection option for boundary handling in 1D correlation #613

Open
meshtag wants to merge 1 commit intoboostorg:developfrom
meshtag:feature/reflection
Open

Add reflection option for boundary handling in 1D correlation #613
meshtag wants to merge 1 commit intoboostorg:developfrom
meshtag:feature/reflection

Conversation

@meshtag
Copy link
Copy Markdown
Member

@meshtag meshtag commented Jun 3, 2021

References

Depends on #612
resolves #608

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@meshtag meshtag added ext/numeric boost/gil/extension/numeric/ google-summer-of-code All items related to GSoC activities labels Jun 3, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 3, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.82%. Comparing base (843ea37) to head (1a2a908).
⚠️ Report is 122 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #613      +/-   ##
===========================================
+ Coverage    78.76%   78.82%   +0.05%     
===========================================
  Files          117      117              
  Lines         5030     5038       +8     
===========================================
+ Hits          3962     3971       +9     
+ Misses        1068     1067       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mloskot
Copy link
Copy Markdown
Member

mloskot commented Jun 3, 2022

@meshtag Could you tell what is the status of this PR? Is this going to be picked up or drop it and close it?

@mloskot mloskot added status/need-feedback Asking for more details about the problem status/work-in-progress Do NOT merge yet until this label has been removed! labels Jun 3, 2022
@meshtag meshtag force-pushed the feature/reflection branch from 060b66c to 1a2a908 Compare June 4, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ext/numeric boost/gil/extension/numeric/ google-summer-of-code All items related to GSoC activities status/need-feedback Asking for more details about the problem status/work-in-progress Do NOT merge yet until this label has been removed!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "Reflection" option for boundary handling in 1D correlation.

4 participants