Skip to content

Switch isl from the isl-for-pluto fork to upstream isl 0.28 - #117

Merged
bondhugula merged 5 commits into
masterfrom
bondhugula/isl_switch_out_fork
Nov 5, 2026
Merged

bondhugula merged 5 commits into
masterfrom
bondhugula/isl_switch_out_fork

Conversation

@bondhugula

@bondhugula bondhugula commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Pluto used the isl-for-pluto fork because of four Pluto-specific commits. None of them is needed any more:

  • isl_map_dim_is_single_valued and isl_pw_aff_from_map_dim only used public isl API. They now live in Pluto as pluto_isl_map_dim_is_single_valued and pluto_isl_pw_aff_from_map_dim.
  • isl_basic_map_range_factor_domain is replaced by pluto_isl_basic_map_range_factor_domain, built from the public isl_multi_aff_domain_map and isl_basic_map_apply_range.
  • The fork's change to isl_ast_build_set_iterators was used by at_each_domain in tool/pet_to_pluto.cpp, to get statement bodies in terms of the statement's own iterators. The access expressions are now built from a separate AST build made from the statement's iteration domain, which gives the same result without the change.

The fifth commit on the fork, an isl_basic_map_reduce_coefficients fix, is already upstream and included in isl 0.28. The isl submodule now points to https://repo.or.cz/isl.git at isl-0.28. Existing clones need git submodule sync && git submodule update to pick up the new URL. The CI workflow now runs git submodule sync before git submodule update, since the self-hosted runner reuses its checkout.

Testing:

  • make check-pluto passes all 66 tests with isl 0.28.
  • All 139 test inputs, run with the pet and default frontends, with and without tiling (556 runs), give the same exit codes and byte-identical generated code as the 0.13.0 release build.

Assisted by Claude.

@bondhugula
bondhugula force-pushed the bondhugula/isl_switch_out_fork branch from 0bdd15e to 4194c14 Compare November 2, 2026 08:12
isl_map_dim_is_single_valued, isl_pw_aff_from_map_dim, and
isl_basic_map_range_factor_domain were only available in the
isl-for-pluto fork. Implement them in pluto using only the public isl
API, as pluto_map_dim_is_single_valued, pluto_pw_aff_from_map_dim, and
pluto_basic_map_range_factor_domain, so that pluto can build with
upstream isl.

Assisted by Claude.
at_each_domain renamed the iterators of the AST build passed to it, via
isl_ast_build_set_iterators, to the statement's iterator names. This
relied on a change to isl_ast_build_set_iterators carried in the
isl-for-pluto fork, and modified a build that is only kept by the
callback.

Instead, construct the access expressions using a separate AST build
whose domain is the statement's iteration domain. The expressions are
then directly in terms of the statement's own iterators, and no index
pullback or iterator renaming is needed.

Assisted by Claude.
Pluto no longer depends on any of the changes carried in the
isl-for-pluto fork, and the remaining fork commit (an
isl_basic_map_reduce_coefficients fix) is included in isl 0.28.

Assisted by Claude.
Self-hosted runners reuse their checkout, so a change to a submodule URL
in .gitmodules does not take effect without git submodule sync. Without
it, the isl submodule is still fetched from the isl-for-pluto fork,
which does not have the upstream isl 0.28 commit.

Assisted by Claude.
Upstream isl on repo.or.cz does not allow fetching a commit by its hash,
which a shallow (--depth 1) submodule update relies on when the
submodule commit is not a branch tip. Check out isl with its full
history, unshallowing an existing shallow checkout on reused runners,
and keep shallow checkouts for the other submodules.

Assisted by Claude.
@bondhugula
bondhugula force-pushed the bondhugula/isl_switch_out_fork branch from 4194c14 to e7e1eed Compare November 2, 2026 08:24
@bondhugula
bondhugula merged commit 2b6fd99 into master Nov 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant