Repository navigation
Switch isl from the isl-for-pluto fork to upstream isl 0.28 - #117
Merged
Merged
Conversation
bondhugula
force-pushed
the
bondhugula/isl_switch_out_fork
branch
from
November 2, 2026 08:12
0bdd15e to
4194c14
Compare
isl_map_dim_is_single_valued, isl_pw_aff_from_map_dim, and isl_basic_map_range_factor_domain were only available in the isl-for-pluto fork. Implement them in pluto using only the public isl API, as pluto_map_dim_is_single_valued, pluto_pw_aff_from_map_dim, and pluto_basic_map_range_factor_domain, so that pluto can build with upstream isl. Assisted by Claude.
at_each_domain renamed the iterators of the AST build passed to it, via isl_ast_build_set_iterators, to the statement's iterator names. This relied on a change to isl_ast_build_set_iterators carried in the isl-for-pluto fork, and modified a build that is only kept by the callback. Instead, construct the access expressions using a separate AST build whose domain is the statement's iteration domain. The expressions are then directly in terms of the statement's own iterators, and no index pullback or iterator renaming is needed. Assisted by Claude.
Pluto no longer depends on any of the changes carried in the isl-for-pluto fork, and the remaining fork commit (an isl_basic_map_reduce_coefficients fix) is included in isl 0.28. Assisted by Claude.
Self-hosted runners reuse their checkout, so a change to a submodule URL in .gitmodules does not take effect without git submodule sync. Without it, the isl submodule is still fetched from the isl-for-pluto fork, which does not have the upstream isl 0.28 commit. Assisted by Claude.
Upstream isl on repo.or.cz does not allow fetching a commit by its hash, which a shallow (--depth 1) submodule update relies on when the submodule commit is not a branch tip. Check out isl with its full history, unshallowing an existing shallow checkout on reused runners, and keep shallow checkouts for the other submodules. Assisted by Claude.
bondhugula
force-pushed
the
bondhugula/isl_switch_out_fork
branch
from
November 2, 2026 08:24
4194c14 to
e7e1eed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pluto used the isl-for-pluto fork because of four Pluto-specific commits. None of them is needed any more:
isl_map_dim_is_single_valuedandisl_pw_aff_from_map_dimonly used public isl API. They now live in Pluto aspluto_isl_map_dim_is_single_valuedandpluto_isl_pw_aff_from_map_dim.isl_basic_map_range_factor_domainis replaced bypluto_isl_basic_map_range_factor_domain, built from the publicisl_multi_aff_domain_mapandisl_basic_map_apply_range.isl_ast_build_set_iteratorswas used byat_each_domainintool/pet_to_pluto.cpp, to get statement bodies in terms of the statement's own iterators. The access expressions are now built from a separate AST build made from the statement's iteration domain, which gives the same result without the change.The fifth commit on the fork, an
isl_basic_map_reduce_coefficientsfix, is already upstream and included in isl 0.28. The isl submodule now points to https://repo.or.cz/isl.git atisl-0.28. Existing clones needgit submodule sync && git submodule updateto pick up the new URL. The CI workflow now runsgit submodule syncbeforegit submodule update, since the self-hosted runner reuses its checkout.Testing:
make check-plutopasses all 66 tests with isl 0.28.Assisted by Claude.