Conversation
Explicitly reject core files with a different bittedness (64-bit vs 32-bit) or endianness than the host. These would never have worked, but until now the reason wasn't clearly surfaced to the user. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
blin
approved these changes
Sep 18, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
- Coverage 78.20% 78.19% -0.02%
==========================================
Files 58 58
Lines 6671 6690 +19
Branches 627 630 +3
==========================================
+ Hits 5217 5231 +14
- Misses 1454 1459 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly reject core files with a different bittedness (64-bit vs 32-bit) or endianness than the host. These would never have worked, but until now the reason wasn't clearly surfaced to the user.
Split out from #358