Skip to content

Improve handling for unsupported core files - #358

Open
godlygeek wants to merge 1 commit into
bloomberg:mainfrom
godlygeek:handle_bad_core_files
Open

godlygeek wants to merge 1 commit into
bloomberg:mainfrom
godlygeek:handle_bad_core_files

Conversation

@godlygeek

Copy link
Copy Markdown
Contributor

Explicitly reject core files with a different endianness than the host. These would never have worked, but until now the reason wasn't clearly surfaced to the user.

Prevent reading past the end of a truncated or malformed core file's NT_FILE note.

Explicitly reject core files with a different endianness than the host.
These would never have worked, but until now the reason wasn't clearly
surfaced to the user.

Prevent reading past the end of a truncated or malformed core file's
``NT_FILE`` note.

Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
@godlygeek godlygeek self-assigned this Sep 17, 2026
@godlygeek
godlygeek requested a review from a team September 17, 2026 22:42
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.92%. Comparing base (7bf481e) to head (7c6594f).

Files with missing lines Patch % Lines
src/pystack/_pystack/corefile.cpp 76.92% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   77.94%   77.92%   -0.02%     
==========================================
  Files          58       58              
  Lines        6693     6719      +26     
  Branches      631      635       +4     
==========================================
+ Hits         5217     5236      +19     
- Misses       1476     1483       +7     
Flag Coverage Δ
cpp 77.92% <86.95%> (-0.02%) ⬇️
python 77.92% <86.95%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godlygeek
godlygeek requested a review from pablogsal September 17, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants