don't report the local pid as the remtran requester - #6201
mohitkhullar wants to merge 1 commit into
Conversation
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
tsa
ssl_san
consumer_non_atomic_default_consumer_generated **quarantined**
ssl_set_cmd
ssl_prefer
ssl_dbname
sc_downgrade [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
9832808 to
1128b42
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
incoherent_slow **quarantined**
sc_resume_logicalsc_generated **quarantined**
tsa
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
1b740b6 to
a1224be
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
tsa
ssl_san
consumer_non_atomic_default_consumer_generated **quarantined**
ssl_set_cmd
ssl_prefer
ssl_dbname
sc_downgrade [timeout] **quarantined**
1641cd5 to
13e4205
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
tsa
consumer_non_atomic_default_consumer_generated **quarantined**
remtran_origin
sc_downgrade [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
tsa
consumer_non_atomic_default_consumer_generated **quarantined**
remtran_origin
sc_downgrade [timeout] **quarantined**
phys_rep_tiered_firstfile_generated [timeout]
truncatesc_offline_generated [timeout] **quarantined**
dorinhogea
left a comment
dorinhogea
left a comment
There was a problem hiding this comment.
looks good, just a few nits
| tran_clnt->conninfo.pename[sizeof(tran_clnt->conninfo.pename) - 1] = '\0'; | ||
| tran_clnt->conninfo.pid = srcpid; | ||
| /* pename is 8 bytes; keep the untruncated uri for access checks */ | ||
| free(tran_clnt->argv0); |
There was a problem hiding this comment.
can this race with collect_osql_session(), which accesses tran_clnt->argv0 with no mutex? (UAF)
There was a problem hiding this comment.
setting only if its NULL
fb0203d to
b2f5ae2
Compare
Signed-off-by: mkhullar <mohit.khullar@gmail.com>
b2f5ae2 to
db45808
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: harness did not run - no test results were produced ⚠.
3 participants
No description provided.